silverstripe-catalogmanager icon indicating copy to clipboard operation
silverstripe-catalogmanager copied to clipboard

Published / Save & Publish button's state doesn't update

Open nfauchelle opened this issue 8 years ago • 4 comments

When you edit a Page via the CatalogManager the Published button's stage doesn't change when you edit a field. If I edit a page normally in the SiteTree then the Published buttons state does change when I start editing a different field (and then click out of it).

When you are creating a new page via the CatalogManager, I notice that the button says 'Save & Publish' by default.

Tested with a fresh 3.5.1 composer install, then composer require littlegiant/silverstripe-catalogmanager

I created a TestHolderPage as the parent and TestPage as the child.

TestPage:
  extensions:
    - CatalogPageExtension
  parentClass:
    - 'TestHolderPage'

TestHolderPage:
  extensions:
    - HidePageChildrenExtension

Is my config for this.

nfauchelle avatar Jan 19 '17 19:01 nfauchelle

@nfauchelle did you ever resolve this?

adrhumphreys avatar Feb 07 '17 00:02 adrhumphreys

@adrhumphreys No I didn't... on my someday maybe list.

nfauchelle avatar Feb 07 '17 00:02 nfauchelle

It looks like the issue is being caused by better buttons, if you disable it, then it will work like a dataobject which is not ideal either

adrhumphreys avatar Feb 07 '17 01:02 adrhumphreys

Looks like this is caused by betterbuttons:

https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/blob/master/javascript/gridfield_betterbuttons.js#L30

Related to this issue: https://github.com/unclecheese/silverstripe-gridfield-betterbuttons/issues/112

Also see: https://github.com/silverstripe/silverstripe-framework/pull/5431

Tom-Alexander avatar Feb 07 '17 10:02 Tom-Alexander