leaflet-groupedlayercontrol icon indicating copy to clipboard operation
leaflet-groupedlayercontrol copied to clipboard

fix for removeLayer

Open matthewberryman opened this issue 7 years ago • 10 comments

Isolates the fix in https://github.com/ismyrnow/leaflet-groupedlayercontrol/pull/46 for removeLayer() - per comments in that pull request, the fix in https://github.com/ismyrnow/leaflet-groupedlayercontrol/pull/50 wasn't complete and we were still seeing the removeLayer error https://github.com/ismyrnow/leaflet-groupedlayercontrol/issues/49 . Have tested this and it solves the issue (thanks @ForgottenLords )

matthewberryman avatar Oct 21 '17 03:10 matthewberryman

Can you please merge this fix into whatever branch, so I can get it with NPM ? I just spend several hours pulling my hair out till I found the source of the bug and got finally to this PR 😭

karlitos avatar Oct 25 '17 15:10 karlitos

OMG merge this please !

TravnikovDev avatar Dec 25 '17 13:12 TravnikovDev

Merge this please. very basic feature that should've been present from the beginning.

vinayakkulkarni avatar Feb 13 '18 06:02 vinayakkulkarni

Any update on merging this changeset?

ka7eh avatar Apr 16 '18 20:04 ka7eh

@ka7eh This package is dead because layers control now included in leaflet http://leafletjs.com/reference-1.3.0.html#control-layers

TravnikovDev avatar Apr 17 '18 08:04 TravnikovDev

@TPABHuKOB thanks for the update.

ka7eh avatar Apr 17 '18 21:04 ka7eh

@TPABHuKOB I do not think Leaflets layer controll is a full replacement of the groupedlayercontrol. How do you do grouping - headings ? You can pass HTML in the Layers labels, but the controls - checkboxes, radios - are placed before the labels. Please see my example.

karlitos avatar Apr 18 '18 08:04 karlitos

I can confirm from my local installation that this pull request fixes the problem with removeLayer. It is a single-line fix, and definitely should be merged into master.

zacharyburnett avatar Aug 28 '18 14:08 zacharyburnett

Also confirmed, nice fix.

corrigancd avatar Aug 04 '19 19:08 corrigancd

Owner? I'm just another person who has faced this problem and solved it myself ...

Azbesciak avatar Oct 05 '19 12:10 Azbesciak