isle icon indicating copy to clipboard operation
isle copied to clipboard

Match `LegoAnimationManager::FUN_100648f0`

Open foxtacles opened this issue 1 year ago • 3 comments

foxtacles avatar Jan 20 '25 23:01 foxtacles

This one is functionally correct and only has one inlined diff from MxQuaternionTransformer::NormalizeDirection():

0x10064a37 : add ebx, 0x4d4
-0x10064a3d : -call Vector3::Vector3 (FUNCTION)
+           : +call Vector4::Vector4 (FUNCTION)
0x10064a42 : lea ecx, [esp + 0x18]
0x10064a46 : push edi
0x10064a47 : mov dword ptr [esp + 0x34], Mx4DPointFloat::`vftable' (VTABLE)
-0x10064a4f : -call Vector3::operator= (FUNCTION)
+           : +call Vector4::operator= (FUNCTION)
0x10064a54 : lea ecx, [esp + 0x20]

I feel like we can close this one.

jonschz avatar Jul 13 '25 11:07 jonschz

Unfortunately this kind of diff will change how functions are ordered in the binary, which is why I added this. But then again I gave up on ordering for now so I'm ok with closing it

foxtacles avatar Jul 13 '25 14:07 foxtacles

If it has a noticable effect, I'd say we leave it open. Now that these comments are here, the next person won't be confused.

jonschz avatar Jul 13 '25 14:07 jonschz