isledecomp
Corrupted Release zip for Windows x64
I'm not sure exactly when it started, unfortuantly, but for at least a week or so every isle-0.1-Windows-x64.zip I have downloaded from the releases has had CRC errors and header errors.
Here's a couple of examples from the most recent release and the one just before. There doesn't seem to be much of pattern as to what part has errors.
Current build:
Penultimate build:
Can confirm. Not sure what's up with this. As a workaround, the .tar.gz archive seems to be fine
The .tar.gz has other issues. Looks like it's missing some dlls as I get error messages from isle-config.exe for:
- libgcc_s_seh-1.dll
- libwinpthread-1.dll
- libstdc++-6.dll
- libb2-1.dll
Other dlls not mentioned in the error are also missing (for example QtSvg.dll and dxil.dll)
Quite a few of the Qt .dlls in the Windows version aren't necessary, such as QtSvg.dll. Additionally, it's not that great having so many .dlls packaged alongside it. I believe #554 is a good suggestion about what to do about this.
However, the problem of the .tar.gz missing those files is certainly worse than just not having QtSvg.dll and other unnecessary files, and indicates a deeper issue.
I'm not getting this issue with the latest builds. If this is intentional, nice work! If not then maybe we should reopen as it could be periodic/random.
I believe this may have been fixed with #665, so hopefully we shouldn't have to re-open this issue.
Funnily enough I downloaded the artifact directly from CI from pull #664 and it worked. #665 just fixed it being in the release.
That's quite annoying. I wonder if it's something with our build script, or if something we're using has a bug.
Turns out It's not sporadic or random, it's only in the release links. Downloading the latest release gives me errors but the artifact from the MSVC (x64) runner works. It was flagged by Windows defender as a trojen, though. Once I allowed it I'm able to extract both zip archives and run everything fine.
