isle-portable icon indicating copy to clipboard operation
isle-portable copied to clipboard

Shared library support

Open Danct12 opened this issue 6 months ago • 8 comments

This allows isle-portable to be built using shared libraries provided by the developer's distribution.

Danct12 avatar Jun 22 '25 19:06 Danct12

Personally i would prefer that it check if there is a system package, if not then it downloads it , unless downloading is off.

AJenbo avatar Jun 22 '25 20:06 AJenbo

Personally i would prefer that it check if there is a system package, if not then it downloads it , unless downloading is off.

I'd prefer things to be reproducible, and not depend on the build system potentially detecting an incomplete package. Enabling DOWNLOAD_DEPENDENCIES` by default will create a working package 99.99% of the time, whereas system packages can might cause issues. I'm also in favor of using system packages, but this is done to avoid having to provide support.

madebr avatar Jun 22 '25 20:06 madebr

I think many of the audio issues that have been reported would go away if the system SDL3 had been used instead. Other then that I agree.

AJenbo avatar Jun 22 '25 20:06 AJenbo

I think many of the audio issues that have been reported would go away if the system SDL3 had been used instead. Other then that I agree.

You mean this issue? I think this is an issue with SDL3, or our usage of it. I was able to reproduce it. If another issue arrives, I'll look into it or ask upstream to have a look at it.

madebr avatar Jun 22 '25 20:06 madebr

I would supset so, unless it's actually because of a system configuration issue on the users end. Requiring the user to force SDL_AUDIODRIVER doesn't seem like a viable solution.

AJenbo avatar Jun 22 '25 21:06 AJenbo

Personally i would prefer that it check if there is a system package, if not then it downloads it , unless downloading is off.

I think it's best to let it up to the user to decide which package provides the headers and install them. Overall, the people that clone and build this knows what they're doing.

Danct12 avatar Jun 23 '25 07:06 Danct12

i admire your faith in humanity

AJenbo avatar Jun 23 '25 11:06 AJenbo

#390 should be closed once this pull request gets merged.

Danct12 avatar Jun 23 '25 12:06 Danct12