Anthony Islas

TYPE: enhancement KEYWORDS: cmake, pnetcdf SOURCE: internal DESCRIPTION OF CHANGES: Problem: The CMake build does not support PnetCDF detection and thus the `external/io_pnetcdf/` code cannot be built. Solution: Write a...

Add default values to controllable cmake options

1

The default options are useful when completely bypassing the configuration prompts. Without these default options certain comparison operators are left evaluating blank expansions that would otherwise lead to malformed syntax

Change glevel 1 and 2 to ints to prevent floating point equality checks

1

All comparisons to glevel1 and glevel2 are against integer values, relying on implicit conversion during the check if done somewhat correctly. When implicit conversion is not done, the floating point...

The ungrib targets in the CMake build are missing the `_UNGRIB` define, analogous to the `_METGRID` and `_GEOGRID` defines found elsewhere in the code. This PR adds the `_UNGRIB` definition...

The preprocessor definition `_MPI` is used to compile WPS with distributed memory capabilities. This define is missing from the set applied when `USE_MPI` is selected in the CMake build. This...

The current logic is flipped to incorrectly negate user requested configuration. The default `[y/N]` prompt is already satisfied by the need to look for explicit `yesValues` matches, otherwise anything else...

Fix relative pathing for tuv_kpp initial code generation

1

TYPE: bug fix KEYWORDS: chem, make SOURCE: internal DESCRIPTION OF CHANGES: Problem: PR #2018 Changed how KPP helper programs generate code by now accepting relative paths. The relative path passed...