Davide Spadini comments

Results 36 comments of


                                            Davide Spadini

Thread Safety

Hi! Not sure what could cause this issue TBH. You can run Pydriller with multiple threads, just specify `num_workers`. This will execute in a ThreadPoolExecutor (https://github.com/ishepard/pydriller/blob/master/pydriller/repository.py#L239). Just be careful that...

Cache the _stats function

Thanks for the PR!

Hardcoding `--ancestry-path` prevents generic `git rev-list` behavior

Hi @bakhtos ! Thanks for pointing this out. As you may know, the difference between `git rev-list A..B`and `git rev-list --ancestry-path=B ^A`is subtle, but still it's there. I found myself...

Repository constructor should accept Path objects

Good point, makes sense to me! I will mark the issue as PR welcome 👍

Paths to repositories and clones can be any `PathLike`

Yeah the test is not your fault. I fixed it now, can you please rebase your branch to master? Also, can you please add a couple of tests to cover...

skip_whitespaces is not applied to Commit._stats()

Good catch! Looking at the documentation of git diff, it seems to be possible to pass ignore whitespaces. So it should be doable here too! I'll mark the issue as...