s1-reader icon indicating copy to clipboard operation
s1-reader copied to clipboard

s1_info.py to take care of antimeridian-crossing

Open seongsujeong opened this issue 1 year ago • 2 comments

This PR is to take care of the case that the S1 frame's area crosses antimeridian when s1_info.py computes the bounding box. The fix is based on the code here

Before:

% python s1_info.py S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip --frame-bbox Found 1 Sentinel-1 SLC products. S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip: [-177.710968, 50.39941, 179.223694, 52.575905]

After:

% python s1_info.py S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip --frame-bbox Found 1 Sentinel-1 SLC products. S1B_IW_SLC__1SDV_20211222T054456_20211222T054526_030134_039920_9391.zip: [178.642044, 50.39941, 182.728027, 52.575905]

seongsujeong avatar Aug 28 '23 17:08 seongsujeong

AFAICT, neither COMPASS nor RTC is using this code in the workflow. git grep does not return anything. Therefore I think the PR should not affect the downstream workflows.

(isce3_0.14.0) COMPASS% git grep _bounds_from_preview (isce3_0.14.0) COMPASS% git grep s1_info

(isce3_0.14.0) RTC% git grep _bounds_from_preview (isce3_0.14.0) RTC% git grep s1_info

seongsujeong avatar Aug 28 '23 19:08 seongsujeong

AFAICT, neither COMPASS nor RTC is using this code in the workflow. git grep does not return anything. Therefore I think the PR should not affect the downstream workflows.

(isce3_0.14.0) COMPASS% git grep _bounds_from_preview (isce3_0.14.0) COMPASS% git grep s1_info

(isce3_0.14.0) RTC% git grep _bounds_from_preview (isce3_0.14.0) RTC% git grep s1_info

Thank you, @seongsujeong . It looks like the function is used here, which seems to be used to inform the frame bbox here.

gshiroma avatar Aug 28 '23 19:08 gshiroma