isce2 icon indicating copy to clipboard operation
isce2 copied to clipboard

Support for SNAPHU v2.0.5

Open forrestfwilliams opened this issue 2 years ago • 5 comments

The SNAPHU unwrapping software bundled with ISCE2 is currently frozen at v1.4.2. However, the SNAPHU maintainers released a newer version of the software (v2.0.5) in December 2021. This version includes two important updates from v1.4.2: support for masking before unwrapping, and support for tile-mode unwrapping.

As mentioned in unwrap masking-relates issue #569 at least some of this functionality is also desired by other users.

Bindings for SNAPHU v2.0.5 are available in ISCE3, and it would be great to see them added to ISCE2 as well. I'm happy to help with the implementation of this feature, but could use help ensuring that it is well integrated with all of ISCE2.

forrestfwilliams avatar May 30 '23 13:05 forrestfwilliams

@comma-never-coma, based on issue #569, it sounds like you may already have code that implements this. Would you mind sharing a fork of ISCE2 that contains the updates you've made?

forrestfwilliams avatar May 30 '23 13:05 forrestfwilliams

Thanks for your advice Williams. I am glad to share my fork and I just made a PR #728. Actually I just made a simple replacement based on the source code, and I would sincerely appreciate it if you could offer me some additional guidance.

comma-never-coma avatar May 31 '23 06:05 comma-never-coma

Thanks @comma-never-coma, yes happy to help!

forrestfwilliams avatar May 31 '23 12:05 forrestfwilliams

I'd propose one PR to update the source code for SNAPHU, then follow-on PRs to add new options/functionality. This should make it easier for the maintainers to review any changes.

forrestfwilliams avatar May 31 '23 12:05 forrestfwilliams

I appreciate your support @forrestfwilliams.

comma-never-coma avatar May 31 '23 13:05 comma-never-coma