fastcdc-py icon indicating copy to clipboard operation
fastcdc-py copied to clipboard

Update dependencies for Python 3.8

Open DukeOfArgyle opened this issue 1 year ago • 1 comments

Hello,

Sorry for sending you a PR out of the blue, but I came across this implementation recently and ran into some conflicts when trying to integrate it into a Python 3.8 project I'm building. I took a quick pass at updating the dependencies to the latest available for 3.8.

I was able to test with pytest and ran it chunked some big files I had lying around on the setups I have access to:

  • Ubuntu 22.04.1 LTS x86_64 - Python 3.10.6
  • Armbian (22.11.1) aarch64 - Python 3.10.6
  • Ubuntu 20.04.4 LTS on Windows 10 x86_64 - Python 3.8.10
  • Debian GNU/Linux 11 (bullseye) aarch64 - Python 3.9.2

It all looked okay to me and installed fine. Let me know if there's any other changes I can or should make.

DukeOfArgyle avatar Jan 30 '23 14:01 DukeOfArgyle

The package is tested against python >= 3.6. Your pull request seems to remove py36 and py37 support. We could try to be less strict by pinning to major versions of dependencies. See: https://python-poetry.org/docs/dependency-specification/#caret-requirements

titusz avatar Feb 19 '23 16:02 titusz