Sam Isaacson

Results 506 comments of Sam Isaacson

We should just make the DSL consistent with what `@reaction` does. Adding parameters at the end can be an optional way to overrule this default.

Probably needs a custom `write` for `ReactionSystem`s, or something that is called by it.

Is it ok to just edit it to 1.6, or do I need to regenerate it under 1.6 to make sure it is consistent / works ok?

@Vilin97 I think I've got this fully updated now, and it looks ok locally, but I do wonder if there is an issue in `DirectCRDirect`. It is still showing the...

I giving this a last run locally to check the html output, and will then need to regenerate the Manifest on 1.7 which I don't currently have installed, but otherwise...

I'll update the remaining jump benchmarks to work with this manifest/project and Catalyst.

@Vilin97 I think this is done -- let me know once you've taken a look at the spatial benchmark and then we can merge if tests have passed.

@Vilin97 thanks for taking a look! For future reference, feel free to use the code suggestion mechanism for small changes like removing the redundancies. Then I can just commit them...

The package version issue doesn't come up locally for me. Could it be because I'm running on a 1.8 rc? Maybe that causes issues with the manifest (though the warning...

It’s finished. Tests just failed from the server job timeout being too short I believe.