Sam Isaacson

Results 506 comments of Sam Isaacson

(So I don't think it really makes sense to push such an approach.)

I don't think we'd want to wrap Julia's sqrt for performance reasons.

We don't handle conversion of non-reactions currently, but assume the user has input them as they desired in their model. So that would need to be added by someone, presumably...

Yes, I agree. Feel free to PR if you want to add that. You can probably reuse what is in MTK for the conversion to make sure the derivatives are...

We should probably get ModelingToolkit to add a dispatch so that the following works: ```julia osys = convert(ODESystem, brusselator) ODEForwardSensitivityProblem(osys, u0, tspan, p) ``` Then we can add a dispatch...

@TorkelE this is handled now? (Modulo recent bugs via Symbolics changes?)

It would probably make sense to just add a SciMLSensitivity extension to ModelingToolkit to define that dispatch, hopefully it could reuse most of the current `ODEFunction` and `ODEProblem` code there...

It looks like `ODEForwardSensitivityFunction` is itself missing needed fields for symbolic indexing and such to work too: https://github.com/SciML/SciMLSensitivity.jl/blob/fde15237adef794d3b544fb62d80db3188abbdf6/src/forward_sensitivity.jl#L10-L37

@LalitChauhan56 are you still planning to do this?

Note that a basic tutorial would just introduce what I summarized in the HISTORY.md file.