Sam Isaacson
Sam Isaacson
New line makes sense to me.
That style has been discussed before I believe. Among other issues it breaks folding of functions and alignment of the first non-argument line in some editors (for example VSCode).
I don't recall where the discussion occurred unfortunately. Either a previous issue here or an older Slack. But generally I wouldn't be in favor of any format change that results...
Given that this is stalled out, and could be discussed endlessly since it is a very subjective issue, perhaps we should just go with @sloede's suggestion of double indenting, maybe...
Code folding at least doesn't seem to have any issue with it.
I find VSCode annoyingly loses indentation information quite frequently, whether it be with the current or previous style. I haven't tried to understand the conditions where it occurs though. Usually...
Moreover, other options that were discussed did not have arguments against them, unlike #[741](https://github.com/domluna/JuliaFormatter.jl/issues/741#issuecomment-1607500407), and some had more apparent support in votes (https://github.com/domluna/JuliaFormatter.jl/issues/741#issuecomment-1607442950). Chris' suggestion of adding a space is...
Looks like the Hawkes one has issues too: https://docs.sciml.ai/SciMLBenchmarksOutput/dev/Jumps/MultivariateHawkes/ Also, why did Synapse appear under the Jumps category too? It seems like it ran there?
Why don’t we just use some of the examples from the Catalyst paper that show different performance characteristics to illustrate which solvers and configurations work best in different cases? Then...
Tau-leaping too.