Isaac Sanders

Infinite timeouts are a bug in Erlang. You should not use them in your library when you have user provided timeouts already passed in.

I’m trying to tell you that your library isn’t using it right. I have connection pool processes that are hanging in the disconnection function because of your timeout on infinity

I know this is the case because the only change I made to fix this is the PR I’ve submitted

You need to be able to pass in the user provided timeout, as well.

It should be passed into the sql_query function as well. And then the gen_server call. > On Nov 18, 2022, at 2:49 AM, Mykhailo Vstavskyi ***@***.***> wrote: > > ...

Why make all of these commits when I have a PR already open for this?

My PR is to close the issue

I used my actual working code to verify the change

@vstavskyi Your example about the `disconnect/2` function doesn't make sense to me. That code doesn't exist in `master` or in my PR.

Your changes to propagate the connect timeout still doesn't respect the individual user's timeout parameter. I have updated my PR so that it can merge with `master`.