node-tar icon indicating copy to clipboard operation
node-tar copied to clipboard

Warning messages on expansion never have `data.recoverable`.

Open robross0606 opened this issue 1 year ago • 2 comments

When handling warnings, the documentation says data.recoverable should be available:

recoverable Boolean. If false, then the warning will emit an error, even in non-strict mode.

However, I have yet to see a warning message come thru with any recoverable property at all when expanding a file. I expected recoverable to be set to true if the warning is recoverable, but the documentation is unclear in this regard. Do false and falsy mean different things here? Under what conditions would one expect to see a recoverable property?

robross0606 avatar Dec 25 '24 17:12 robross0606

I'm also seeing that data.file never seems to be available on warnings when using x().

robross0606 avatar Dec 25 '24 18:12 robross0606

Yes, false and falsey mean different things here. If recoverable is set to actual factual Boolean false, then it's not a recoverable error and the unpack/parse action must be aborted.

Can you provide a reproduction case for not seeing data.file on extraction warnings? If you're giving x() a file option, then that'll always be included on the warning data, as far as I can see.

isaacs avatar Sep 21 '25 18:09 isaacs