IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

Adds option to change the clipping behavior for all Cameras and unifies the default

Open pascal-roth opened this issue 1 year ago • 1 comments

Description

This PR adds an option to define the clipping behavior for depth images generated by RayCasterCamera and Camera. In addition, it unifies the clipping behavior for the depth images of all camera implementations. Per default, all values exceeding the range are clipped to zero for both distance_to_image_plane and distance_to_camera depth images. Prev. RayCasterCamera clipped the values to the maximum value of the depth image, Camera did not clip them and had a different behavior for both types, and TiledCamera clipped the values to zero.

Needs PR #617 to be merged

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have run the pre-commit checks with ./isaaclab.sh --format
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [x] I have added my name to the CONTRIBUTORS.md or my name already exists there

pascal-roth avatar Aug 28 '24 14:08 pascal-roth

@Mayankm96 added test for all the other depth clipping formats, should be good to go now

pascal-roth avatar Sep 28 '24 16:09 pascal-roth

@Mayankm96 quick ping, can we get that merged?

pascal-roth avatar Oct 13 '24 18:10 pascal-roth