IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

Add `CODEOWNERS` file with a few examples

Open jsmith-bdai opened this issue 1 year ago • 2 comments

Description

This PR adds in a CODEOWNERS file so that we can better handle the review request process.

NOTE: This version is not finalized, please add suggestions to other areas on this PR. We can constantly add more as well, I just wanted to get an initial version up and filled in the things I knew off the top of my head :smile:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x] I have run the pre-commit checks with ./isaaclab.sh --format
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [x] I have added my name to the CONTRIBUTORS.md or my name already exists there

jsmith-bdai avatar Aug 08 '24 19:08 jsmith-bdai

Looks like a cool feature to me! I would personally do not include teams as there might be a lot of changes within the people. But that can be up for discussion

pascal-roth avatar Aug 09 '24 13:08 pascal-roth

Looks like a cool feature to me! I would personally do not include teams as there might be a lot of changes within the people. But that can be up for discussion

@pascal-roth Thanks! Please add any section of the code for which you would like to be a reviewer for as suggestions

jsmith-bdai avatar Aug 09 '24 15:08 jsmith-bdai

@jsmith-bdai I took a stab at having a more thorough listing in there. Still a pretty tentative list. We can work on improving it in our discussions.

Mayankm96 avatar Aug 23 '24 10:08 Mayankm96