IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

Applies semantic_tags to ground

Open KumoLiu opened this issue 8 months ago • 1 comments

Description

The check here: the RigidBodyMaterialCfg used by GroundPlaneCfg lacks a semantic_tags attribute. So the semantic_tags will not set to the ground correctly, then the semantic_segmentation_mapping can not been correctly mapped.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable. Ground didn't been mapping correctly.

Before After
image Screenshot 2025-04-29 at 17 57 24

Checklist

  • [ ] I have run the pre-commit checks with ./isaaclab.sh --format
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [ ] I have added my name to the CONTRIBUTORS.md or my name already exists there

KumoLiu avatar Apr 30 '25 15:04 KumoLiu

Thanks a lot for the fix! Could you please also update the CHANGELOG and extension.toml files to include a note on the change and the reason behind it?

kellyguo11 avatar May 01 '25 00:05 kellyguo11

also the rigid body test seems to be failing, could you double check locally to see if it passes for you?

kellyguo11 avatar May 02 '25 22:05 kellyguo11

Thanks a lot for the fix! Could you please also update the CHANGELOG and extension.toml files to include a note on the change and the reason behind it?

Hi @kellyguo11, added in this commit https://github.com/isaac-sim/IsaacLab/pull/2410/commits/1194d63bcca44a7fe060fd685ad7275f166bfc55. Also check the test passed locally. Thanks.

KumoLiu avatar May 03 '25 06:05 KumoLiu

I don't know why the build failed, could you please help take a look at it?

KumoLiu avatar May 03 '25 06:05 KumoLiu

Hi @Mayankm96 , could you please help take a look at the build failure?

Thanks in advance.

Nic-Ma avatar May 06 '25 16:05 Nic-Ma