IsaacLab
IsaacLab copied to clipboard
Fixes DCMotor clipping for negative power and adds actuator tests
Description
This PR adds tests for actuator initialization, configuration, and computation for Implicit, IdealPD, and DC motor actuators.
This PR also updates the DCMotor model to clip based on a four quadrant DC motor model. This will fix improper clipping in the negative power regions (i.e. positive torque and negative velocity or negative torque and positive velocity).
NOTE: This PR is dependant on the pytest migration in: 2034 This PR includes changes made in 2291 and would be an alternate candidate.
Fixes #2139
Type of change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
- [x] I have run the
pre-commitchecks with./isaaclab.sh --format - [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have updated the changelog and the corresponding version in the extension's
config/extension.tomlfile - [x] I have added my name to the
CONTRIBUTORS.mdor my name already exists there