IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

Fixes how camera intrinsics are used for creation and update

Open jtigue-bdai opened this issue 11 months ago • 1 comments

Description

This PR changes how the camera intrinsic matrix is used to create usd cameras and updated from usd camera parameters so that if the intrinsic matrix is accessed in CameraData it will be the same as the intrinsic matrix used to create the USD camera.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • [x] I have run the pre-commit checks with ./isaaclab.sh --format
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • [x] I have added my name to the CONTRIBUTORS.md or my name already exists there

jtigue-bdai avatar Jan 03 '25 15:01 jtigue-bdai

@pascal-roth here is that camera intrinsic PR I was talking about.

jtigue-bdai avatar Jan 03 '25 15:01 jtigue-bdai