IsaacLab icon indicating copy to clipboard operation
IsaacLab copied to clipboard

[Proposal] Add camera local frame setter and both local and global frame getter

Open lhy0807 opened this issue 1 year ago • 1 comments

Proposal

The current implementation of the Camera sensor only exposes the global pose setter. However, pose getter and local pose setter is also needed for my project needs.

Motivation

I need to get the pose of the camera, however this getter function has not been implemented in the current Camera sensor interface. Setting the camera local pose is also needed.

Alternatives

I could get the pose using self._view. However, I think a more proper way is to expose this function in the Camera class.

Additional context

N/A

Checklist

  • [x] I have checked that there is no similar issue in the repo (required)

Acceptance Criteria

Add the criteria for which this task is considered done. If not known at issue creation time, you can add this once the issue is assigned.

  • [ ] Add get_world_poses function to Camera class
  • [ ] Add set_local_poses function to Camera class
  • [ ] Add set_local_poses_from_view function to Camera class

lhy0807 avatar Sep 24 '24 22:09 lhy0807

Hello @lhy0807 !

On a cursory examination of the code, I also wasn't able to find a way to get this information without directly accessing self._view. We already use this to set_world_pose of the camera, so we should probably have an equivalent get_world_pose in the same way. Local and other non global frame transformations would then be handled in the usual way. Good suggestion!

mpgussert avatar Oct 03 '24 00:10 mpgussert