Debugify icon indicating copy to clipboard operation
Debugify copied to clipboard

[Patch Request] MC-73186 (Model Gap Fix)

Open RaptaG opened this issue 3 years ago • 10 comments

Mojang Bug Report ID

MC-73186

Mod Loader

N/A

Bug adhere to the guidelines.

  • [X] I made sure that this bug adheres to the guidelines.

Has not already been requested.

  • [X] I am certain this patch has not already been requested.

Has not already been implemented.

  • [X] I know that this patch isn't already in the latest version of the mod.

RaptaG avatar Apr 30 '22 13:04 RaptaG

We’re not interested in skidding mods

Wyvest avatar Apr 30 '22 15:04 Wyvest

We’re not interested in skidding mods

Besides that, this is a bug too, reported in the bug tracker and filling all the requirements for a patch request (according to Debugify's requirements)

RaptaG avatar Apr 30 '22 15:04 RaptaG

Reopening because as RaptaG states, this is a bug. The item model fix mod is quite complex, if this was to be fixed the vanilla way, it shouldn't have any options and should "just work"

isXander avatar Apr 30 '22 18:04 isXander

@PepperCode1 hi! Do you mind adding this mod into debugify?

isXander avatar May 07 '22 19:05 isXander

My main issue with merging Item Model Fix into Debugify is precisely that it has multiple options. I will try to do some research to figure out why unlerp/outline still produces small gaps and based on what I come up with, further discussion can happen. The other problem is that Item Model Fix does not fix the block part of that bug.

PepperCode1 avatar May 27 '22 16:05 PepperCode1

Hiya. Thanks for your cooperation.

isXander avatar May 30 '22 18:05 isXander

~~Patch when~~ (Just Kidding)

RaptaG avatar Jun 22 '22 13:06 RaptaG

Model Gap Fix implements a better fix and it should be used instead of Item Model Fix, because it fixes it from the core of the problem. https://github.com/Fabulously-Optimized/fabulously-optimized/issues/473

RaptaG avatar Sep 24 '22 18:09 RaptaG

Version 1.8 has completely fixed the bug on both block and item side, @isXander make sure to take a look!

RaptaG avatar Oct 13 '22 13:10 RaptaG

Like I have previously stated, I don't have any knowledge about this part of Minecraft. I don't feel comfortable adding this fix at the current moment.

isXander avatar Oct 13 '22 20:10 isXander