Controlify icon indicating copy to clipboard operation
Controlify copied to clipboard

[Bug] Empty bindings reset upon restarting Minecraft

Open KiyoNetcat opened this issue 11 months ago • 6 comments

Current Behaviour

When clearing a binding that is bound to an action by default (e.g sprint), the binding gets reset after restarting Minecraft. This does not occur with any bindings that are bound to a different button instead, nor does it occur with any that are unbound by default.

Expected Behaviour

After unbinding the action, the action continues to stay unbound upon a restart.

Screenshots

No response

Reproduction Steps

  1. Unbind an action that has a non-empty default binding (e.g Sprint)
  2. Close and restart Minecraft

Logs


Mod Version

v2.0.1+1.21-fabric

Controller

Xbox One S Controller (as emulated via Sunshine)

Bluetooth

  • [ ] Yes

Operating System

Linux/SteamOS

ARM

  • [ ] Yes

Additional Information

Not sure if this is relevant to this issue (may be another bug), but every time I restart Minecraft, I get prompted to submit a report for if my controller works, regardless of if I skip or submit it.

Just to make sure...

  • [x] I have made sure I am using the latest version of Controlify for the latest version of Minecraft.
  • [x] I have made sure there are no other issues describing the same problem on the issue tracker.

KiyoNetcat avatar Jan 25 '25 04:01 KiyoNetcat

I cannot get this to repeat. There may be something affecting your config causing it to reset. Can you send latest.log?

isXander avatar Jan 25 '25 15:01 isXander

here's a few logs where the issue occured (started minecraft, had the controller submission pop up, unbound sprint, went into a world and left, stopped minecraft): https://mclo.gs/m9FjRFm https://mclo.gs/91c7gvH https://mclo.gs/t8mTG41

edit, should've also uploaded, here's a log file where the issue didn't occur: https://mclo.gs/hDwHpdr

something i also noticed is that it seems to immediately detect my controller "disconnecting" and "connecting", then prompting me to submit the controller data.

KiyoNetcat avatar Jan 25 '25 16:01 KiyoNetcat

bit more testing, i consistently do not replicate the issue if i connect a controller after starting minecraft: https://mclo.gs/ANvfP1Q https://mclo.gs/v1Xpud5 however, if my controller is connected and sending inputs before starting minecraft, the issue comes back consistently: https://mclo.gs/VeMOFUa https://mclo.gs/oWa4fik

i'd guess there's a bug that occurs if the controller is detected before minecraft finishes loading

KiyoNetcat avatar Jan 25 '25 16:01 KiyoNetcat

I get this. My use case is more unique as I'm playing on my phone, connected to my PC via moonlight streaming software. This software, with controller connected to my phone, shows as an Xbox controller on my PC. Asks about submitting controller info each time. Have the same identifier in config.

setzke avatar Feb 01 '25 07:02 setzke

I get this. My use case is more unique as I'm playing on my phone, connected to my PC via moonlight streaming software. This software, with controller connected to my phone, shows as an Xbox controller on my PC. Asks about submitting controller info each time. Have the same identifier in config.

that actually seems to be my exact case as well, i was also playing with a controller connected to my mobile device streaming from my pc, right down to it being emulated as an xbox controller on the pc side.

KiyoNetcat avatar Feb 02 '25 01:02 KiyoNetcat

Adding -- even if it's not empty. I have D-pad up and D-pad left set to custom mod commands and every time I start Minecraft I need to go into the controller's settings and clear d-up (chat) and d-left (item pick).

setzke avatar Feb 08 '25 05:02 setzke