Ivan Schurawel

@thornbill any idea when this might get a final look through? I'd love to get this feature added.

@thornbill @dmitrylyzo Happy new year to you both. I wanted to check in to see if I could get a final review on this.

Thanks for the update @thornbill. I'm sorry to hear that you were ill. I hope you are now doing well. I did not mean to sound like I was rushing...

> I only have one minor comment regarding logging really. I did some quick testing and it seems to work as expected. 🎉 Unless @dmitrylyzo has some additional feedback, I'd...

EDIT: fix and explanation [here](https://github.com/jellyfin/jellyfin-web/pull/3906#discussion_r1103124915) ~~@dmitrylyzo @thornbill Just a heads up to you both, I noticed that direct play now seems to be broken in this branch. The break seems...

I have removed the work to fix the stuck track cues for dev firefox builds into a separate draft PR #4349. This work is out of the scope of this...

I also have a general question. I noticed as I was working on the last commit that the `getPlayerData` method prepares an object for state, but we never actually use...

> And the second one: `playerData.secondarySubtitleStreamIndex` is still not reset if the secondary subtitle is wrong (bug above), but it is now unnoticeable. [This line](https://github.com/jellyfin/jellyfin-web/blob/ba47fb65e35fbde1492497a081b990af58456373/src/components/playback/playbackmanager.js#L3016) reverts it even if we...

> You may need to check if both subtitles are compatible for secondary (in `autoSetNextTracks`) and reset `DefaultSecondarySubtitleStreamIndex` if they are not. This will probably work (as a workaround), but...

@thornbill Alright, we figured out the kinks. Please give this a final look when you get the chance. :raised_hands: