register icon indicating copy to clipboard operation
register copied to clipboard

Add formatting as workflow (as requested)

Open tobezdev opened this issue 1 year ago • 7 comments

This PR is not a domain creation request. Reference pull #13966

Version 2 of adding Prettier formatting to is-a-dev/register! New in this version:

  • moved manual workflow to automatic:
    • [+] .github/workflows/formatting.yml - create the workflow
    • {~] package.json - added configuration for the formatter
    • [~] package-lock.json - added script to run formatting on-change
    • [+] .prettierrc - add configuration for formatting to run with
    • [+] .prettierignore - add a list of files for formatting to ignore

Please request changes on .prettierignore before merging this to ensure the formatter only edits the correct files. You may also want to check/test the workflow to ensure it runs as intended.

tobezdev avatar May 15 '24 10:05 tobezdev

Sure @wdhdev, I'll do it later on today :)

tobezdev avatar May 22 '24 06:05 tobezdev

Sure @wdhdev, I'll do it later on today :)

Have you done this yet? If so, please send me the action run.

wdhdev avatar May 25 '24 08:05 wdhdev

Sure @wdhdev, I'll do it later on today :)

Any updates?

omsenjalia avatar May 28 '24 08:05 omsenjalia

This pull request has been marked as stale due to inactivity and will be closed. Comment anything on this PR to prevent it

github-actions[bot] avatar Jun 04 '24 14:06 github-actions[bot]

@tobezdev Any updates?

iostpa avatar Jun 05 '24 07:06 iostpa

Yes. I have managed to recreate the workflow on a private test repo. The formatting seemed to work fine, but I'm trying to troubleshoot a check failure (though it seems to work fine) I'll add another comment here when I find a fix to this.

tobezdev avatar Jun 05 '24 09:06 tobezdev

Yes. I have managed to recreate the workflow on a private test repo. The formatting seemed to work fine, but I'm trying to troubleshoot a check failure (though it seems to work fine) I'll add another comment here when I find a fix to this.

I tried. any nonzero exit code in any step will result in the failure of the check as a whole. (therefore stopping checks)

MaskDuck avatar Jun 07 '24 05:06 MaskDuck

Any updates?

iostpa avatar Jul 05 '24 18:07 iostpa

Any updates?

Going to be completely honest with you, I completely forgot about the existence of this PR. I've been very busy with personal stuff, so apologies for that. Could someone remind me where we were with this? Thanks.

tobezdev avatar Jul 08 '24 23:07 tobezdev

Any updates?

Going to be completely honest with you, I completely forgot about the existence of this PR. I've been very busy with personal stuff, so apologies for that. Could someone remind me where we were with this? Thanks.

So from what I see, you were trying to troubleshoot a check failure, then MaskDuck tried out your workflow and pointed out that any nonzero exit code will result in the failure of the workflow as a flow, therefore stopping checks. That's the last update I've seen on this PR. If you have no idea on what I'm saying, you could read the 2 messages that I've summarized that are above my follow up or you can even check your repo to see what you did there the last time.

iostpa avatar Jul 09 '24 13:07 iostpa

I'm going to go ahead and close this. I appreciate the efforts however it is too complicated and would require thorough review from our team which we do not have the resources for.

wdhdev avatar Jul 11 '24 04:07 wdhdev