toxcore icon indicating copy to clipboard operation
toxcore copied to clipboard

Published 20 hours ago • verified publisher icon irungentoo

Classify file transfers.

Open Jookia opened this issue 11 years ago • 5 comments

Right now file transfers are simple, but adding a type parameter and perhaps specified limits would allow the following to be implemented across clients in a uniform manner:

  • Inline images/video
  • Quick recordings of video/voice
  • Avatars

Jookia avatar Sep 26 '14 09:09 Jookia

Good idea, because some file types can be transferred without user agreement (images? like in iMessage)

iShift avatar Sep 26 '14 11:09 iShift

What about passing an optional MIME type in every file transfer request? With standardized types as "audio/x-tox-short-message-speex" we can trigger special behaviors and enforce additional limitations (e.g. download audio messages automatically, but only from authorized friends and limited to x messages of at most y KB each).

To avoid breaking the protocol, we may add another packet type PACKET_ID_FILE_SENDREQUEST_MIME and make the current PACKET_ID_FILE_SENDREQUEST an alias to an empty type.

ittner avatar Sep 26 '14 14:09 ittner

Related: https://github.com/irungentoo/toxcore/issues/1080

suhr avatar Oct 01 '14 12:10 suhr

I just sent a PR to implement this. Check out #1148.

ittner avatar Nov 02 '14 23:11 ittner

file transfer api has changed, and has 2/3 of these do you want to open a new issue for all the types you'd like to nee in core? Or leave this one?

GrayHatter avatar Oct 20 '15 17:10 GrayHatter