BoundingBoxOutlineReloaded icon indicating copy to clipboard operation
BoundingBoxOutlineReloaded copied to clipboard

Hotkey is hardcoded

Open Jaxlyfe opened this issue 1 year ago • 4 comments

Due to B for backpack, I wanted to change the binding to something I wont accidentally hit every 5 seconds when building. But when changing the key bindings they show as conflicting, and will work for the duration of that session, but after relogging they will no longer work. Changing them via the config file provides the same issue.

This really feels like the key bindings are hard coded to BBOR.

MC : 1.19.2 Forge : 43.2.4 BBOR : 2.5.1 (2.6 provided the same issue)

Jaxlyfe avatar Feb 27 '23 09:02 Jaxlyfe

I'm running into the same issue. If I change it, the hotkey shows and responds as the new key, but on game restart, while the hotkey still shows the new key, it goes back to using "b" as the actual hotkey. It also seems to block propogation of that key, as the backpack doesn't still also open.

brianfreud avatar Apr 08 '23 19:04 brianfreud

I'm no expert, but it appears as though you're re-registering the hotkey every time the mod gets loaded (ie, client restart), which is why it's ignoring remappings through client config.

https://github.com/irtimaled/BoundingBoxOutlineReloaded/blob/9b3d975c355cb4087f9f33ff510e9b7e0f808025/src/main/java/com/irtimaled/bbor/client/ClientProxy.java#L17

brianfreud avatar Apr 12 '23 12:04 brianfreud

Can confirm bug. Very irritating.

DrCryllus avatar Sep 17 '23 03:09 DrCryllus

Bumping issue because it's still a thing and seems to be across versions (i'm seeing it on 1.18.2)

MoonliteDelight avatar Oct 11 '23 21:10 MoonliteDelight