angular4-material-table icon indicating copy to clipboard operation
angular4-material-table copied to clipboard

Published 20 hours ago • verified publisher icon irossimoline

Enabled strictNullChecks. Note: has breaking changes

Open hossameldeen opened this issue 6 years ago • 3 comments

As described in #17 , I'm opening this PR just in case you want to check out the solution. But I'm neutral towards merging it; it provides compile-time check for something we're kind-of sure of, but, unfortunately, it breaks backward compatibility.

Sorry for opening it as PR, but I want to delete my fork and want to keep the project's knowledge in one place: your repo, if you don't mind.

Mostly expecting the PR to be closed/rejected.

Thanks again!

hossameldeen avatar Jun 30 '18 00:06 hossameldeen

Hi @hossameldeen, have you checked the comments?

irossimoline avatar Jul 20 '18 23:07 irossimoline

Yup, long time ago, and replied to them too :-)

In case you can't see them, here's the first reply, and the the other one. Please, tell me if there are any comments I've missed.

hossameldeen avatar Jul 21 '18 08:07 hossameldeen

My bad, the comment has been pending to send for weeks, here it is.

Thank you @hossameldeen.

irossimoline avatar Jul 21 '18 16:07 irossimoline