ivozprovider
ivozprovider copied to clipboard
Make externallyRated a company setting
Type Of Change
- [ ] Small bug fix
- [x] New feature or enhancement
- [ ] Breaking change
Checklist:
- [x] Commits are named and have tag following commit rules
- [x] Commits are split per component (schema, web/admin, kamusers, agis, ..)
- [x] Changes have been tested locally
- [ ] Fixes an existing issue (Fixes #XXXX)
Description
In Artemis externallyRated setting was related to Carriers. In Halliday, externallyRated is going to be related to Companies.
This way, calls from a given company may or may not be rated, no matter which carrier is used to place calls.
Additional information
This is a breaking change for platforms using a mix of externallyRated carriers and non-externallyRated ones for a given company. This was quite weird, as a call from a client A to a destination B may have rating details (price and cost) depending on the carrier used to place that specific call at that specific moment:
- If used carrier was marked as externallyRated: no rating details were calculated.
- Otherwise, rating details were calculated.
This was even more misleading as clients may call to to destinations not included in their pricing plans, as long as call was placed using a carrier marked as externallyRated. Depending on outgoing routing rules and carrier state in the moment of the call (up or down), a call may have price and may be validated against active pricing plan or not.
In Halliday externallyRated setting is much simpler:
- If a client is marked with this setting, no destination will be validated against active pricing plan and call will have no rating details. These clients won't use any rating feature.
- If a client is not marked with this setting, it will only call to destinations incluided in active pricing plan and call will have rating details. These clients may use any rating feature.