Brian Alexander

Results 27 comments of Brian Alexander

I think another aspect of this might be to more clearly surface the fact that a plugin HAS a dependency, not just IS a dependency. This would help introduce and...

In response to @afragen: > Add a Requires item in the plugin description field I mean to leverage the [already proposed `Requires plugins` plugin PHP header](https://github.com/WordPress/wp-plugin-dependencies/issues/4). So if my plugin...

In response to @afragen: > ...Display `Requires` instead of `Required by`. How do you propose the user find those dependencies. Would you make them search the plugin repository? > I...

@afragen: > Scale will be an issue. The issue will be present for both the requiring plugin and the dependency. Both should show relevant data. The information should be in...

@shaunandrews, thank you so much for the graphical deep-dive in how this might be realized! 🙌🏻

In response to @t-hamano: > ``` > # Avoid using single or double quotes for multiline patterns > files: | > **.md > ``` Ah, interesting -- good to know!

@t-hamano, what do you think about addressing the intent behind the directory filters that were originally introduced in 3c34c484a9e370b8b7661b95f4745b8c65b6359e? The workflow's [intent is stated as](https://github.com/WordPress/gutenberg/blob/72e40c1522c307f8ae93bc4900f71f550811b490/.github/workflows/php-changes-detection.yml#L1), "Confirm if PHP changes require...

Thanks for sharing that discussion. I guess it should be reconciled to clarify whether _any_ PHP file change in the Gutenberg repo is intended here (including plugin-specific code in the...

The return for `db_version()` was updated to `8.0` in https://github.com/WordPress/sqlite-database-integration/commit/768f8cc6d2a2707f744bba31cb0e5421a68c0f4f (following WordPress's [minimum required version bump](https://core.trac.wordpress.org/ticket/60036)). Should this issue be marked as resolved? Regarding the proposals mentioned in https://github.com/WordPress/sqlite-database-integration/issues/24#issuecomment-1466896373, I...

In response to @arnt: > It also does not add a tests/formatting/sanitizeEmail.php; I wouldn't mind adding one... Absolutely, please **do** add unit tests (or updates to existing tests) for `sanitize_email()`....