App-p icon indicating copy to clipboard operation
App-p copied to clipboard

Dependency on XML::Hash::LX and XML::Simple not declared

Open ppisar opened this issue 9 years ago • 2 comments

The 0.0400 version uses XML::Hash::LX and XML::Simple modules, but the META.yml does not list them.

ppisar avatar Nov 10 '15 13:11 ppisar

I wanted to make those deps "optional". Installing xml deps have a tendency to fail if certain xml system libs are not already installed on the system. Do you have a suggestion for a better solution?

ironcamel avatar Nov 10 '15 18:11 ironcamel

On Tue, Nov 10, 2015 at 10:27:43AM -0800, Naveed Massjouni wrote:

I wanted to make those deps "optional".

Maybe using "eval 'require XML::Hash::LX'" to add or remove the subs from the commands array could do the job.

But definitely mentioning the dependencies somewhere would be great. E.g. you could add this into Makefile.PL:

recommends => { 'XML::Hash::LX' => '0', 'XML::Simple' => '0', },

-- Petr

ppisar avatar Nov 11 '15 09:11 ppisar