lambda
lambda copied to clipboard
Docker username required when pushing to Hub
Using lambda with the default configuration of Docker Hub + IronWorker requires that the image name have a username/ in it. Currently the blog post and the docs do not make this explicit enough.
- Update docs
I do not agree with enforcing that all images created via ironcli have a username. This is because users may be using private registries or not deploying to IW. Rather I recommend the following:
- The
aws-importcommand already accepts a-imageflag to specify an alternate name. This will be made clear in the docs. - If
publish-functiondetects an "invalid" image name, print out a nice message explaining what is wrong, and also print the exact docker command the user can execute to fix the problem. This is becausepublish-functionis the only thing affected by this requirement. - Optional: Add a flag to
aws-importandcreate-functionthat picks up the login credentials for Hub from docker configuration and auto prefixes images.
Also added note here https://github.com/iron-io/lambda/commit/d2288f000406bed53ad821f75e6878704d3dd735
@supereli