ironfish icon indicating copy to clipboard operation
ironfish copied to clipboard

Information about the removed accounts is not deleted from the node database

Open SNSMLN opened this issue 2 years ago • 1 comments

Description

I created several test accounts. For example, ironfish accounts:create TEST command. After that I deleted them all. For example, ironfish accounts:remove TEST command

Checking the current list of accounts

ironfish accounts:list
Connecting to /home/ironfish/.ironfish/ironfish.ipc
SNSMLN
SNSMLN_POOL

It looks like there are only 2 accounts.

But at the same time, long-deleted test accounts are constantly visible in the node log

мая 29 11:59:16 rig02 ironfish_node[4037336]: RECV WebRtc lJo2/Xd: NewTransaction (8)                   
мая 29 11:59:16 rig02 ironfish_node[4037336]: Removing mined blocks for account help                       
мая 29 11:59:16 rig02 ironfish_node[4037336]: Finished removing mined blocks for account help              
мая 29 11:59:16 rig02 ironfish_node[4037336]: Removing mined blocks for account default                 
мая 29 11:59:16 rig02 ironfish_node[4037336]: Finished removing mined blocks for account default        
мая 29 11:59:16 rig02 ironfish_node[4037336]: Removing mined blocks for account TEST                                                     
мая 29 11:59:16 rig02 ironfish_node[4037336]: Finished removing mined blocks for account TEST           
мая 29 11:59:16 rig02 ironfish_node[4037336]: Removing mined blocks for account TEST    
мая 29 11:59:16 rig02 ironfish_node[4037336]: Finished removing mined blocks for account TEST                                            
мая 29 11:59:16 rig02 ironfish_node[4037336]: RECV WebRtc SXqWH8g: NewTransaction (8)                    
мая 29 11:59:16 rig02 ironfish_node[4037336]: RECV WebRtc mqynvmv: NewTransaction (8) (repeated 31 times)
мая 29 11:59:17 rig02 ironfish_node[4037336]: RECV WebRtc pXO08YT: NewTransaction (8)                                                     
мая 29 11:59:17 rig02 ironfish_node[4037336]: RECV WebRtc pXO08YT: NewTransaction (8)                                                     
мая 29 11:59:17 rig02 ironfish_node[4037336]: RECV WebRtc pXO08YT: NewTransaction (8)                                                     
мая 29 11:59:17 rig02 ironfish_node[4037336]: RECV WebRtc pXO08YT: NewTransaction (8)                                                     
мая 29 11:59:17 rig02 ironfish_node[4037336]: Removing mined blocks for account help                                                      
мая 29 11:59:17 rig02 ironfish_node[4037336]: Finished removing mined blocks for account help                                             
мая 29 11:59:17 rig02 ironfish_node[4037336]: Removing mined blocks for account default
мая 29 11:59:17 rig02 ironfish_node[4037336]: Finished removing mined blocks for account default
мая 29 11:59:17 rig02 ironfish_node[4037336]: Removing mined blocks for account TEST 
мая 29 11:59:17 rig02 ironfish_node[4037336]: Finished removing mined blocks for account TEST              
мая 29 11:59:17 rig02 ironfish_node[4037336]: Removing mined blocks for account TEST                    
мая 29 11:59:17 rig02 ironfish_node[4037336]: Finished removing mined blocks for account TEST              
мая 29 11:59:17 rig02 ironfish_node[4037336]: RECV WebRtc F12b+8p: NewTransaction (8)                      
мая 29 11:59:17 rig02 ironfish_node[4037336]: SEND WebRtc nr4I0LK: NewTransaction (8) (repeated 2 times)

SNSMLN avatar May 29 '22 09:05 SNSMLN

i don't think this is a bug. This is removing mined blocks from the account you just deleted. It's expected behavior and triggered from this.accounts.onAccountRemoved

wd021 avatar Sep 29 '22 15:09 wd021

We've removed the code in question entirely. The mined block indexer has been removed.

NullSoldier avatar Jan 03 '23 18:01 NullSoldier