irods icon indicating copy to clipboard operation
irods copied to clipboard

Published 20 hours ago • verified publisher icon irods

`rxCollCreate` returns different error codes based on presence of `RECURSIVE_OPR__KW` flag

Open korydraughn opened this issue 1 year ago • 3 comments

  • [ ] main
  • [ ] 4-3-stable

Let's say we want to try and create a collection in a place where we don't have permission to. One may expect rxCollCreate to return the same permission error in all cases, but that's not what happens.

When RECURSIVE_OPR__KW is passed, you get SYS_INVALID_INPUT_PARAM. When RECURSIVE_OPR__KW is NOT passed, you get CAT_NO_ACCESS_PERMISSION.

This was demonstrated using 4.3.1.

korydraughn avatar Jan 09 '24 20:01 korydraughn

I don't think this is a refactor as a behavioral change is being proposed... Seems more like a bug to me as the expected behavior does not match the observed behavior. Thoughts?

alanking avatar Jan 09 '24 20:01 alanking

Well, I don't think it's a bug. It's more of an enhancement IMO. I don't know that the original implementation was intended to have these operations result in identical error codes.

korydraughn avatar Jan 09 '24 20:01 korydraughn

Definitely a change in behavior, which means this has to go into 4.4/5.0.

Consider whether it's worth adding a label for behavioral change.

korydraughn avatar Jan 10 '24 13:01 korydraughn