irods icon indicating copy to clipboard operation
irods copied to clipboard

Published 20 hours ago • verified publisher icon irods

Investigate removing irods_dynamic_cast

Open alanking opened this issue 3 years ago • 2 comments

  • [ ] main

Investigate whether it is safe to do this now: https://github.com/irods/irods/blob/d1a0be69c01509613085488886d988d6ea2d8f4e/server/core/include/irods_dynamic_cast.hpp#L12-L16

alanking avatar Dec 07 '21 19:12 alanking

The test suite passes when this file and its references are removed. We are going to wait on merging for now until we can confirm that this does not produce any ill effects. I have linked the commit which removes the hack from a branch in my fork.

alanking avatar Jan 21 '22 20:01 alanking

Pulling into 4.3.0 so it remains visible.

trel avatar Jan 21 '22 21:01 trel