metalnx-web icon indicating copy to clipboard operation
metalnx-web copied to clipboard

collection paging (page size) not working

Open michael-conway opened this issue 6 years ago • 8 comments

page size setting seems to not work on collection listing

michael-conway avatar Jun 06 '18 13:06 michael-conway

it's pretty bizarre, the datatables statement sets up paging, and the paging chrome is displayed, but the paging doesn't work.

The collections view needs a big facelift anyhow, so that it can support actual iRODS paging and stored queries, so in the interest of time I'm proposing to temporarily sidestep this one and take a fresh look at a faster and cleaner display of collections in the next iteration....there are currently a chain of 3 ajax calls to get a listing that is causing some performance issues anyhow...

michael-conway avatar Jun 27 '18 18:06 michael-conway

iow turn datatables paging off for the 2.0.0 release. the net impact on the users is actually small, and getting datatables paging out of the way will eliminate some level of confusion when the iRODS collections get really big....

michael-conway avatar Jun 27 '18 18:06 michael-conway

sounds okay to me - just don't want to lose track of it. bumping to 2.1

trel avatar Jun 27 '18 18:06 trel

Yeah I committed a patch. Remember that data table paging is within the currently retrieved set, not within the iRODS collection, so it's paging a partial 'page' from iRODS...errrgh.

Worth talking about, but several complaints on rendering speed on collections browsing so something with a focus on performance and 'true' iRODS paging needed.

michael-conway avatar Jun 27 '18 18:06 michael-conway

I am OK with this, but doing this cuts off the ability to sort on columns. That was why we put datatables in. Sorting was a heavily requested feature. And for the record when people start working with collections containing 15K+ files you will find we start getting server 500 errors because the browser cache overloads. Another reason why you see pagination and not infinity scrolling.

When we look at this for R2.1 we need to make sure that the solution do allow column sorting and does not break with massive collections. And before you give me grief about the silliness of having 15K files in a collection this requirement came up because when we interviewed LSHC people they told us it was not uncommon for a data "dumping" area to have over 35K objects before the process of categorizing started.

sgworth avatar Jun 29 '18 16:06 sgworth

it should allow column sorting, the datatables paging is just set to false, everything else is the same

On Fri, Jun 29, 2018 at 12:04 PM Stephen Worth [email protected] wrote:

I am OK with this, but doing this cuts off the ability to sort on columns. That was why we put datatables in. Sorting was a heavily requested feature. And for the record when people start working with collections containing 15K+ files you will find we start getting server 500 errors because the browser cache overloads. Another reason why you see pagination and not infinity scrolling.

When we look at this for R2.1 we need to make sure that the solution do allow column sorting and does not break with massive collections. And before you give me grief about the silliness of having 15K files in a collection this requirement came up because when we interviewed LSHC people they told us it was not uncommon for a data "dumping" area to have over 35K objects before the process of categorizing started.

On Wed, Jun 27, 2018 at 2:58 PM Mike Conway [email protected] wrote:

Yeah I committed a patch. Remember that data table paging is within the currently retrieved set, not within the iRODS collection, so it's paging a partial 'page' from iRODS...errrgh.

Worth talking about, but several complaints on rendering speed on collections browsing so something with a focus on performance and 'true' iRODS paging needed.

On Wed, Jun 27, 2018 at 2:46 PM Terrell Russell < [email protected]> wrote:

sounds okay to me - just don't want to lose track of it. bumping to 2.1

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <

https://github.com/irods-contrib/metalnx-web/issues/52#issuecomment-400789594

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/ABC-LRUnZvSob2DXSijF6UApQpSwAccyks5uA9MHgaJpZM4UctCT

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/irods-contrib/metalnx-web/issues/52#issuecomment-400792551 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AHBV0-2gO9qkoq6uI1yHrxDMlN4bJ2aDks5uA9XegaJpZM4UctCT

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/irods-contrib/metalnx-web/issues/52#issuecomment-401399696, or mute the thread https://github.com/notifications/unsubscribe-auth/ABC-LTi27DmFf29ZITL73Fsm8k_k9fREks5uBk_xgaJpZM4UctCT .

michael-conway avatar Jun 29 '18 16:06 michael-conway

push out to coll browser redesign, this can start as soon as we get search in as we'll be able to use proper ajax and vue.js to accomplish this, folding in functionality we had in cloud browser

michael-conway avatar Nov 20 '19 18:11 michael-conway

let's leave everything in a milestone, and then bump milestones as necessary.

trel avatar Nov 21 '19 07:11 trel