Irit Katriel

### Checklist - [x] I added a descriptive title - [x] I searched open reports and couldn't find a duplicate ### What happened? In https://github.com/conda/conda/blob/ba2d3483f322cab5681e71762e31574435ee4614/conda/gateways/disk/delete.py#L220 there is a `return` statement...

return in finally can swallow exceptions

6

In three places in your codebase, you have a `return` statement in a `finally` block, which would swallow any in-flight exception: https://github.com/celery/billiard/blob/366ac5f9a708a64fc48f94da465189f9309288ab/billiard/connection.py#L349 https://github.com/celery/billiard/blob/366ac5f9a708a64fc48f94da465189f9309288ab/billiard/connection.py#L351 https://github.com/celery/billiard/blob/366ac5f9a708a64fc48f94da465189f9309288ab/billiard/pool.py#L1856 This means that if a `BaseException`...

return in finally can swallow exception

2

In the [expr_match](https://github.com/zopefoundation/Zope/blob/072af95e25954837f2dc39ebeddf290042682144/src/OFS/FindSupport.py#L194) function: ``` def expr_match(ob, ed, c=InstanceDict, r=0): e, md, push, pop = ed push(c(ob, md)) try: r = e.eval(md) finally: pop() return r ``` The `return` in...

return in finally can swallow exceptions

1

In https://github.com/segmentio/analytics-python/blob/ec1c05ae566d7a32f0b8b5f58752a3fe79319087/segment/analytics/consumer.py#L84 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if a `BaseException` (such as `KeyboardInterrupt`) is raised from the...

In https://github.com/census-instrumentation/opencensus-python/blob/2e0710bf9ef733f29607418e51f0719422155361/contrib/opencensus-ext-flask/opencensus/ext/flask/flask_middleware.py#L205 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if a `BaseException` (such as `KeyboardInterrupt`) is raised from the...

create an internals documentation folder in the cpython repo

4

The internals documentation is scattered in markdown files in the codebase, as well as parts which are in the dev guide. We would like to have it in one place,...

return in finally can swallow exceptions

1

In https://github.com/albertogeniola/MerossIot/blob/58de4e0594aa2a471c0c50b7230ceaca72b596d6/meross_iot/http_api.py#L372 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if an exception other than `ValueError`(including`BaseException` such as `KeyboardInterrupt`) is...

In https://github.com/lobocv/pyperform/blob/97d87e8b9ddb35bd8f2a6782965fd7735ab0349f/pyperform/thread.py#L74 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if a `BaseException` (such as `KeyboardInterrupt`) is raised from the...

return in finally swallows exceptions

1

In https://github.com/newrelic/newrelic-python-agent/blob/7d6da2c2326f38487e901ccd51c1d16b86fa8469/tests/framework_aiohttp/_target_application.py#L97 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if an unhandled exception (including a `BaseException` such as `KeyboardInterrupt`)...

In https://github.com/pahaz/sshtunnel/blob/aa7342e55e49529fea020a09ba8f1eed33eb896f/sshtunnel.py#L1040 there is a `return` statement in a `finally` block, which would swallow any in-flight exception. This means that if an unhandled exception (including a `BaseException` such as `KeyboardInterrupt`)...