Zinovy Nis

Results 17 comments of Zinovy Nis

[clang-tidy] Add a new check 'replace-with-string-view'

So I have 2 things to be done: - rename the check - add options for custom string types (most probably in the next PR)

[clang-tidy] Add a new check 'replace-with-string-view'

What's done: - renamed to `modernize-use-string-view` - added a lot of tests and some code had been fixed due to that - simplified some conditions - minor cleanups. Thanks a...

[clang-tidy] Add a new check 'replace-with-string-view'

Here's what I've got on the LLVM project trunk [use-string-view.patch](https://github.com/user-attachments/files/24273974/use-string-view.patch)

[clang-tidy] Add a new check 'replace-with-string-view'

> ```diff > getArcana > ``` Thanks. Looks like overloaded functions? So let's ignore overloaded functions as I do for virtual/override?

[clang-tidy] Add a new check 'replace-with-string-view'

> ```c++ > std::string getArcana(const TemplateName &NNS) { > return std::string{""}; // no warning, explicit ctor call > return std::string(""); // no warning > } > ``` It works even...

[clang-tidy] Add a new check 'replace-with-string-view'

> > > ```c++ > > > std::string getArcana(const TemplateName &NNS) { > > > return std::string{""}; // no warning, explicit ctor call > > > return std::string(""); // no...

[clang-tidy] Add a new check 'replace-with-string-view'

Any other comments? If no, I'd like to merge it tomorrow.