iree icon indicating copy to clipboard operation
iree copied to clipboard

[MLIR] Extend vector.scatter to support tensors

Open hanhanW opened this issue 6 months ago • 1 comments

Both vector.scatter and vector.gather only accepted memref in the beginning: https://github.com/llvm/llvm-project/commit/19dbb230a245d3404a485d8684587c3d37c198d3

We extended the vector.gather when we had a need for vectorization: https://github.com/llvm/llvm-project/commit/66c2b76846246fcd1df31e1928b0df44a8fe43e1

It is not a blocker because we plan to use it for vector distribution pipeline, and it can happen on memrefs. However, I think it's worth to complete the functionality of map_scatter decomposition. Filing an issue for tracking it.

hanhanW avatar Jun 18 '25 23:06 hanhanW

cc @banach-space who identified the same problem before: https://github.com/llvm/llvm-project/commit/1e61b374ba3ba2891dc1abda732b0b9263216785

hanhanW avatar Jun 18 '25 23:06 hanhanW

@hanhanW
Could you please provide the current status of this issue?
If it hasn't been addressed yet, I would like to take it on.

sakupan102 avatar Oct 23 '25 13:10 sakupan102

No progress since I filed the issue. PRs are welcome. It is an upstream change and may involve others inputs.

hanhanW avatar Oct 23 '25 17:10 hanhanW

Hi @hanhanW , if no one is working on this, could I pick up this issue?

HalfBloodPrince010 avatar Oct 27 '25 17:10 HalfBloodPrince010

@HalfBloodPrince010 I'm currently working on this issue.

sakupan102 avatar Oct 27 '25 17:10 sakupan102

@sakupan102 Sounds good! Sorry missed your comment was 4 days ago.

HalfBloodPrince010 avatar Oct 27 '25 17:10 HalfBloodPrince010

@hanhanW
I've created a pull request for this issue. Could you please review it? https://github.com/llvm/llvm-project/pull/165548

sakupan102 avatar Oct 29 '25 12:10 sakupan102