iree icon indicating copy to clipboard operation
iree copied to clipboard

Remove Config() constructor in favor of explicit API for creating devices

Open stellaraccident opened this issue 5 years ago • 6 comments

It is currently very easy when doing non default construction of a SystemContext to create multiple Config instances for the same device. The API needs to provide a mechanism to create one and only one Config per driver/device. Since this will need to be substantially upgraded for eventual multi-device config at some point, it would be good as a short term measure to have an explicit API like get_default_config_for_driver() that can enforce the proper lifetimes until we build the general solution (this will keep things from spidering).

Reported from a customer.

stellaraccident avatar Jun 04 '20 05:06 stellaraccident

@krzys-ostrowski

stellaraccident avatar Jun 04 '20 05:06 stellaraccident

#3937 enables this.

benvanik avatar Nov 22 '20 00:11 benvanik

@stellaraccident still relevant?

benvanik avatar Jul 01 '22 03:07 benvanik

@stellaraccident Still active?

allieculp avatar Jul 18 '22 16:07 allieculp

Yes, i have a patch for this but needs reviving

stellaraccident avatar Jul 18 '22 17:07 stellaraccident

@stellaraccident I will go ahead and mark P2, please bump up if we plan to actively work on this!

allieculp avatar Jul 20 '22 17:07 allieculp