iree icon indicating copy to clipboard operation
iree copied to clipboard

[Integrate] RISC-V 64 has numerical issues for dynamic_pack_simple_pad_mode test

Open hanhanW opened this issue 7 months ago • 4 comments

It is identified in https://github.com/iree-org/iree/pull/20924, I haven't got the root cause yet.

See https://github.com/iree-org/iree/actions/runs/15315366130/job/43088371934?pr=20924

iree/runtime/src/iree/modules/check/module.cc:493: Failure
Failed
Expected equality of these values. Contents does not match.
  lhs:
    2x2x3x3xi32=[[[0 1 2][4 5 6][8 9 10]][[3 1 2][7 0 1][11 9 10]]][[[12 13 14][0 0 1][8 9 10]][[15 13 14][0 0 1][8 9 10]]]
  rhs:
    2x2x3x3xi32=[[[0 1 2][4 5 6][8 9 10]][[3 0 0][7 0 0][11 0 0]]][[[12 13 14][0 0 0][0 0 0]][[15 0 0][0 0 0][0 0 0]]]

[  FAILED  ] module.static_pack_simple_pad_mode, where GetParam() = 2 (15 ms)
[ RUN      ] module.dynamic_pack_simple_pad_mode
iree/runtime/src/iree/modules/check/module.cc:493: Failure
Failed
Expected equality of these values. Contents does not match.
  lhs:
    2x2x3x3xi32=[[[0 1 2][4 5 6][8 9 10]][[3 1 2][7 5 6][11 9 10]]][[[12 13 14][0 5 6][0 9 10]][[15 13 14][0 5 6][0 9 10]]]
  rhs:
    2x2x3x3xi32=[[[0 1 2][4 5 6][8 9 10]][[3 0 0][7 0 0][11 0 0]]][[[12 13 14][0 0 0][0 0 0]][[15 0 0][0 0 0][0 0 0]]]

[  FAILED  ] module.dynamic_pack_simple_pad_mode, where GetParam() = 3 (9 ms)

https://github.com/iree-org/iree/blob/b94055809b15a3a8494e7f945dc915b1c42a445c/tests/e2e/linalg/pack.mlir#L71-L94

hanhanW avatar May 29 '25 04:05 hanhanW

cc @rednoah91

hanhanW avatar May 29 '25 04:05 hanhanW

Candidate PR: https://github.com/llvm/llvm-project/pull/144170

mshockwave avatar Jun 13 '25 22:06 mshockwave

Candidate PR: llvm/llvm-project#144170

The fix was merged and I confirmed that it fixes the pack.mlir test case. I'll send another PR to re-enable this test for RISC-V once this (LLVM) patch is integrated in the next sync

mshockwave avatar Jun 17 '25 02:06 mshockwave

Thanks @mshockwave, I'll help re-enable the test after the fix is propagated to IREE!

hanhanW avatar Jun 17 '25 17:06 hanhanW