iree icon indicating copy to clipboard operation
iree copied to clipboard

Merge `round_dims_to` and `matmul_narrow_{M,N}` into a single `max_padding` array attribute

Open bjacob opened this issue 1 year ago • 0 comments

This is a take 2 on https://github.com/iree-org/iree/issues/17553. There, I had suggested renaming round_dims_to to max_padding and making it a scalar, while retaining matmul_narrow_{M,N} overriding it for narrow dimensions and clarifying the whole semantics.

Last week we discussed in-person that it would be even nicer to resolve this the other way around: keep the renaming of round_dims_to to max_padding but keep that an array attribute and instead drop the separate matmul_narrow_{M,N}, folding their semantics into that.

bjacob avatar Jun 24 '24 15:06 bjacob