iree icon indicating copy to clipboard operation
iree copied to clipboard

[hip][cuda] Update event allocation and collection.

Open AWoloszyn opened this issue 1 year ago • 2 comments

The existing system was not sufficient for graphs, as they can be run out of order and have different behavior for event recording.

This does not entirely solve the problem for re-use, if we ever want to simultaneously submit more than one graph at a time, but is much closer.

AWoloszyn avatar Jun 07 '24 15:06 AWoloszyn

Just found another issue w.r.t. threading (we unfortunately do need a mutex), fix up soon.

AWoloszyn avatar Jun 10 '24 16:06 AWoloszyn

@AWoloszyn, could you add in the description in a few words what the problem was and how you solved it? It will pick up that as a commit message when it gets merged.

sogartar avatar Jun 13 '24 16:06 sogartar

BTW, it would be nice that in the future to use merge instead of rebase + force push--it's easier to see where the last review was up to and only check the newly added stuff. (I can still largely tell from the commit history but we don't have GitHub review mechansims showing the difff "since last review".) :D

We do, but force pushing breaks it. I think merging also breaks it though :P

image

ScottTodd avatar Jul 12 '24 22:07 ScottTodd

ha, interesting. didn't know we have that! will try out next time :)

antiagainst avatar Jul 13 '24 05:07 antiagainst