iree icon indicating copy to clipboard operation
iree copied to clipboard

[DT] Make the padding sizes of encodings be a scalar.

Open lialan opened this issue 1 year ago • 2 comments

  • rename round_dims_to to max_padding
  • make max_padding a generic case single value attribute

Progress towards https://github.com/iree-org/iree/issues/17553

lialan avatar Jun 07 '24 14:06 lialan

I think a better solution could be using std::optional<int64_t> padFactor. It's more aligned with how we define the padFactor in EncodingBased.td.

@hanhanW I it is much better to do in this way. I will do a subsequent PR for it later. For now just leave it as is.

lialan avatar Jun 10 '24 19:06 lialan

@lialan I took a stab at better PR title and linked the related issue to the PR description. Feel free to make it better if you got some ideas. (I'm not good at naming.)

hanhanW avatar Jun 11 '24 17:06 hanhanW

Dropping this in favor of https://github.com/iree-org/iree/issues/17729

lialan avatar Jul 06 '24 15:07 lialan