[CPU][ArmSME] Enable transposes for f32 and f64
Since [1] transposes may get eliminated by folding into defining vector.transfer_read.
[1] https://github.com/llvm/llvm-project/pull/92562
ci-extra: build_test_all_arm64
Can you add ci-extra: build_test_all_arm64 as the last line of your PR summary (and push something to re-trigger CI)?
Can you add
ci-extra: build_test_all_arm64as the last line of your PR summary (and push something to re-trigger CI)?
Looks like CI ran but I'll add it to summary for any updates.
Can you add
ci-extra: build_test_all_arm64as the last line of your PR summary (and push something to re-trigger CI)?Looks like CI ran but I'll add it to summary for any updates.
Just noticed ci-extra: build_test_all_arm64 was skipped, will push to trigger.
I've moved this to draft, will re-open once https://github.com/llvm/llvm-project/pull/92562 lands in the next LLVM integration.
Thanks Cullen!
Sorry for the delay, I've kept skipping this one without realising that this is the patch :) I blame the title:
[CPU][ArmSME] Enable transposes for f32 and f64
That's not what's happening here, is it? IIUC, this patch adds logic to identify transpose-like
linalg.genericOps and then, for ArmSME, adds "scalable" flags to the tiling config. For X86 there should be no changes, right?That's my understanding based on the code - is this correct? If yes, could you update the summary?
Thanks Cullen!
Sorry for the delay, I've kept skipping this one without realising that this is the patch :) I blame the title:
[CPU][ArmSME] Enable transposes for f32 and f64
That's not what's happening here, is it? IIUC, this patch adds logic to identify transpose-like
linalg.genericOps and then, for ArmSME, adds "scalable" flags to the tiling config. For X86 there should be no changes, right?
It is what's happening, albeit indirectly since linalg.transpose ops are converted to linalg.generic by GeneralizeLinalgNamedOps`. But yes, no changes to X86.
That's my understanding based on the code - is this correct? If yes, could you update the summary?
Not quite, but I'll clarify in the summary to make it clearer 👍
Would be good to wait for either @hanhanW or @dcaballe review.
AFAIK, Diego is distracted with other activities these days :)
This looks good to me, what do you think @hanhanW and @MacDue ?
Thanks, just one nit! LGTM!
thanks for reviewing! Fixed the final nit 👍