iree icon indicating copy to clipboard operation
iree copied to clipboard

Generalize overriding llvm func attr flags in translation info

Open Groverkss opened this issue 1 year ago • 2 comments

Previously, we were specifically querying for waves_per_eu attr in translation info in ROCMTarget. This patch makes this general by attaching a llvm function attribute override dictionary in the translation info instead which can be set.

Groverkss avatar May 13 '24 12:05 Groverkss

Not sure where to add tests for checking if serialization works

Groverkss avatar May 13 '24 13:05 Groverkss

Not sure where to add tests for checking if serialization works

Yeah good question. I wonder if there is an llvm attribute that would do something we could lit test against.

qedawkins avatar May 13 '24 13:05 qedawkins

Not sure where to add tests for checking if serialization works

I am not sure there is an easy way. You probably need to dump the IR after the OPT phase, but before LLC phase and check the flag exists..

MaheshRavishankar avatar May 13 '24 18:05 MaheshRavishankar