iree icon indicating copy to clipboard operation
iree copied to clipboard

Enable Python bindings builds/tests in 'runtime' CI builds.

Open ScottTodd opened this issue 2 years ago • 2 comments

Hoping to add more coverage for these tests: image

Some of the tests use compiler APIs though: https://github.com/openxla/iree/blob/278bcf0283769a1303fa6a9205527940da653a17/runtime/bindings/python/CMakeLists.txt#L256-L258

ScottTodd avatar Dec 11 '23 17:12 ScottTodd

Ping?

ScottTodd avatar Jan 10 '24 00:01 ScottTodd

Seeing some errors after syncing: https://github.com/iree-org/iree/actions/runs/9164893455/job/25197219527?pr=15878#step:4:1068

/work/runtime/bindings/python/io.cc:217:26: error: no member named 'bool_' in namespace 'nanobind'
        if (py::cast<py::bool_>(self_object.attr("is_host_allocation"))) {
                     ~~~~^
/work/runtime/bindings/python/io.cc:217:32: error: type name requires a specifier or qualifier
        if (py::cast<py::bool_>(self_object.attr("is_host_allocation"))) {
                               ^

edit: fixed by installing build requirements (via python venv)

ScottTodd avatar May 20 '24 21:05 ScottTodd

Ping, @sogartar I think you wanted to build off of this?

ScottTodd avatar May 28 '24 19:05 ScottTodd

Ping? (Just noticed these tests still not being included in the lightweight 'runtime' builds on https://github.com/iree-org/iree/pull/17959)

ScottTodd avatar Jul 19 '24 04:07 ScottTodd

Hah yeah. They were close but had some gaps. I'll sync this then merge. Thanks for looking!

ScottTodd avatar Jul 19 '24 04:07 ScottTodd

before: https://github.com/iree-org/iree/actions/runs/10001221131/job/27644479262?pr=17959#step:9:1067

iree/modules/check/test                                       =   0.00 sec*proc (4 tests)
iree/task                                                     =   1.95 sec*proc (8 tests)

after: https://github.com/iree-org/iree/actions/runs/10002430990/job/27647713462?pr=15878#step:9:1081

iree/modules/check/test                                       =   0.00 sec*proc (4 tests)
iree/runtime/bindings/python                                  =   1.73 sec*proc (7 tests)
iree/task                                                     =   1.79 sec*proc (8 tests)

ScottTodd avatar Jul 19 '24 04:07 ScottTodd