iree icon indicating copy to clipboard operation
iree copied to clipboard

Use past average latency for comparison on pull request benchmarks

Open antiagainst opened this issue 2 years ago • 3 comments

Right now we are using the last landed commit's latency for comparison when performing benchmarks on pull requests. With just one single data point, it causes quite some fluctuation and wrong flagging of improvements/regressions. We should expose an API in dana to query the average latency for a benchmark series and use that for comparison on pull requests. (dana already have such information calculated; just need to do the plumbing to expose it.)

antiagainst avatar Jun 02 '23 18:06 antiagainst

I actually filed the same issue #13377 before. This one seems to be more complete, closed the previous one.

pzread avatar Jun 02 '23 18:06 pzread

Another idea is to use checksums to filter out noise and potentially aggregate the latencies from the same artifacts to get more accurate results (post the idea from #12152)

pzread avatar Mar 29 '24 17:03 pzread

Unassigned myself as I'm not working on this currently

pzread avatar May 01 '24 17:05 pzread

obsolete

antiagainst avatar Aug 12 '24 23:08 antiagainst