ircv3-specifications icon indicating copy to clipboard operation
ircv3-specifications copied to clipboard

Add draft account-extban spec

Open causal-agent opened this issue 3 years ago • 13 comments

I asked about this on IRC and people seemed in agreement that such an ISUPPORT token should exist.

causal-agent avatar Jul 08 '21 22:07 causal-agent

I think this is great. I'd like to get some indication that this is something that would be implemented by server devs. Ideally Insp, Unreal, Solanum, ergo. Can't remember if there was interest when this was first being discussed.

jwheare avatar Nov 02 '21 21:11 jwheare

I also think this is great, as extbans currently can't be implemented by any form of automation (bots/scripts, GUIs, or simply showing a human-friendly message in the log) without scrapping the server name from the version in RPL_MYINFO.

Two issues that may need to be addressed first, though:

  • Unreal does not allow any mask, only complete names and two special values (0 and *) https://www.unrealircd.org/docs/Extended_bans#Group_3:_selectors
  • both Unreal and Insp are planning to introduce longer forms for their extban names (a small string instead of a single char), so they would not be able to fit both in this token. Let's make it comma-separated?

progval avatar Nov 02 '21 21:11 progval

Ref https://bugs.unrealircd.org/view.php?id=5991 for the new (inconsistent) extban names.

emersion avatar Nov 10 '21 07:11 emersion

I think even if the only semantic requirement of accountextban is that it works on complete account names, it would still fulfill its function. Not sure quite how to word that in the spec.

causal-agent avatar Nov 10 '21 18:11 causal-agent

Yeah, that's reasonable

progval avatar Nov 10 '21 18:11 progval

@progval Would this be enough to address your concern?

"Servers MUST support matching exact account names. Servers MAY support matching account masks and other server-specific extensions."

I don't think we need to mention the longer forms of extbans.

emersion avatar Dec 08 '21 23:12 emersion

@progval Would this be enough to address your concern?

"Servers MUST support matching exact account names. Servers MAY support matching account masks and other server-specific extensions."

Sure.

I don't think we need to mention the longer forms of extbans.

I'd rather we did. Unreal 6 will transform short extbans to long extbans, so clients need to know the long form in order to display it.

progval avatar Dec 08 '21 23:12 progval

I'd rather we did. Unreal 6 will transform short extbans to long extbans, so clients need to know the long form in order to display it.

Hm. This is unfortunate. Would it be fine for these servers to only advertise the longer form, and not the short form? This would avoid having to advertise multiple account extban tokens.

emersion avatar Dec 08 '21 23:12 emersion

But Insp 4 won't convert whatever the user wrote, so clients may see either

progval avatar Dec 08 '21 23:12 progval

@causal-agent Could you make this a comma-separated list of names? eg. ACCOUNTEXTBAN=a,account for Unreal >=6 and ACCOUNTEXTBAN=R,account for Insp >= 4, and ACCOUNTEXTBAN=a for Solanum

progval avatar Mar 20 '22 08:03 progval

@causal-agent Could you make this a comma-separated list of names? eg. ACCOUNTEXTBAN=a,account for Unreal >=6 and ACCOUNTEXTBAN=R,account for Insp >= 4, and ACCOUNTEXTBAN=a for Solanum

What should I do with this sentence:

Servers publishing the ACCOUNTEXTBAN token MUST also publish the EXTBAN token, and the value of the ACCOUNTEXTBAN token MUST appear in the value of the EXTBAN token.

Is there an equivalent for long extban names? Should I just remove the second requirement?

causal-agent avatar Mar 22 '22 01:03 causal-agent

There is no equivalent. Yes, I think you should remove it; EXTBAN is completely useless for anything but the prefix anyway, because it does not say anything about the semantics.

progval avatar Mar 22 '22 07:03 progval

Implemented by Limnoria in a feature branch: https://github.com/progval/Limnoria/compare/testing...account-ban

progval avatar Nov 23 '22 18:11 progval