PHP-PasswordLib icon indicating copy to clipboard operation
PHP-PasswordLib copied to clipboard

HHVM (HipHop VM) current limits output to the first 255 bytes of output....

Open navecommunications opened this issue 11 years ago • 1 comments

... If the prefix exceeds this, the returned string never contains

any added entropy, nor can it ever grow passed 255 bytes trapping us in an infinite loop if we request a larger string. Concatenating the prefix and the generated should theoretically be faster through the uniqid function, so we'll only concatenate our own if we're running HHVM, as well as have two seperate loops available so we only have to evalute if we're running HHVM once vs every iteration of a singular loop.

navecommunications avatar Mar 11 '14 20:03 navecommunications

Why not open this as a bug against HHVM, as it's clearly working fine in core?

ircmaxell avatar Mar 13 '14 02:03 ircmaxell